Opencl INLINE #5638
Merged
Opencl INLINE #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After cc2f223 we got it too often. This is more like it.
magnumripper
force-pushed
the
opencl-inline
branch
2 times, most recently
from
93b6e56 to
50fdace
Compare
This currently ends up with "rotate(x, 32U-(n))" on all platforms anyway so no net change.
Define NOINLINE as "__attribute__((noinline))" which has been seen working. Replace all uses of the latter with the macro. Drop the questionable "inline" macro and instead define INLINE as 'static inline', which should be the right thing, for anything put POCL and MESA which we've seen problems with in the past. Then use this macro only for inlines that were replaced by the old inline macro (for now). Closes openwall#5618
magnumripper
force-pushed
the
opencl-inline
branch
from
50fdace to
433dcac
Compare
solardiz
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define NOINLINE as
__attribute__((noinline))which is has been seen working. Replace all uses of the latter with the macro. Drop the questionable "inline" macro and instead define INLINE asstatic inline, which should be the right thing, for most targets. Use this only for inlines that were replaced by the old inline macro (so not to make an uncontrollable mess at once).Closes #5618